Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README release commands to sign release tags #221

Merged
merged 3 commits into from
Jun 16, 2020

Conversation

sbesson
Copy link
Member

@sbesson sbesson commented Jun 16, 2020

Minor improvements from my experience releasing omero-py 5.7.0.

A second minor is that if the previous dev version does not match the expected release version (in my case 5.6.3.dev0 was released as 5.7.0), the default command will obviously create an undesired tag/commit. Options are either:

  • to review the current version and have a preliminary bump of bumpversion --no-tag [major|minor|patch]
  • to override the content of .bumpversion.cfg using `bumpversion release --current-version/--new-version
    No strong preference either way but if people have a inclination towards either of these options, I can certainly add a sentence to the README as part of this PR

@joshmoore
Copy link
Member

Doh! Somewhere along the line we lost this:

(base) /opt $grep sign */.bumpversion.cfg
ome-zarr-py/.bumpversion.cfg:sign_tags = True
omero-dropbox/.bumpversion.cfg:sign_tags = True
omero-figure/.bumpversion.cfg:sign_tags = True
omero-signup/.bumpversion.cfg:sign_tags = True

@sbesson
Copy link
Member Author

sbesson commented Jun 16, 2020

Updated to set the defaults in the configuration file instead.

@joshmoore
Copy link
Member

Thanks. I've blindly been assuming I've had this active everywhere.

@sbesson sbesson requested a review from joshmoore June 16, 2020 13:17
@sbesson sbesson merged commit 8d711f5 into ome:master Jun 16, 2020
@sbesson sbesson deleted the sign-tags branch June 21, 2021 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants