Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use BytesIO for default thumbnail #104

Merged
merged 1 commit into from
Jan 7, 2020
Merged

Use BytesIO for default thumbnail #104

merged 1 commit into from
Jan 7, 2020

Conversation

will-moore
Copy link
Member

To test, visit /webclient/render_thumbnail/{ID}/ where {ID} is a random number that is not a valid image ID (not found).

Should see the default thumbnail:

Screen Shot 2020-01-02 at 15 12 24

mtbc
mtbc approved these changes Jan 6, 2020
View reviewed changes
Copy link
Member

@mtbc mtbc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Certainly works on py3 CI.

@joshmoore joshmoore merged commit 7c4c1f8 into ome:master Jan 7, 2020
jburel pushed a commit to jburel/omero-web that referenced this pull request Oct 7, 2021
@will-moore
Port all non-test code from omero_private ome#104
17213f6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtbc mtbc mtbc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@will-moore @mtbc @joshmoore