Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix webadmin search firefox #125

Merged
merged 1 commit into from
Feb 14, 2020
Merged

Fix webadmin search firefox #125

merged 1 commit into from
Feb 14, 2020

Conversation

will-moore
Copy link
Member

Fixes layout of the search field on Groups and Experimenters webadmin pages on firefox.
To test:

  • Search field should not be obscured behind the edge of the table header.

manics
manics approved these changes Feb 12, 2020
View reviewed changes
Copy link
Member

@manics manics left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Screen Shot 2020-02-12 at 09 47 23

vs

Screen Shot 2020-02-12 at 09 47 14

and similarly for users

@chris-allan
Copy link
Member

@jburel: We've also seen this so would be nice to get in, ready to merge?

@jburel
Copy link
Member

jburel commented Feb 14, 2020

PR approved. Merging

@jburel jburel merged commit 3aae3ea into ome:master Feb 14, 2020
@will-moore will-moore deleted the fix_webadmin_search_firefox branch February 26, 2020 09:24
@jburel jburel changed the title fix webadmin search firefox Fix webadmin search firefox Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manics manics manics approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@will-moore @chris-allan @jburel @manics