Query string ids

[will-moore]

Fix #223
Where URLs use e.g. ?image=1&image=2, we now also support more concise ?image=1,2.
This allows us to avoid query strings becoming too long (greater than 4k) with e.g. 500 images.

Also, where we use ?Image=1,2, we now also support ?Image=1&Image=2.

The webclient now uses the more concise form for loading right panel and loading annotations (required when filtering centre panel).

To test:

• Need to have omero.web.page_size set to 500
• Open a Dataset with > 500 images - e.g. https://merge-ci.openmicroscopy.org/web/webclient/?show=dataset-13651
• Select them all - right panel should load
• Expand the various annotation panels in right panel
• Try adding e.g Tag, Rating, Key-Value pairs, Comments to ~500 images
• Filter centre panel by Tag, Rating, Key-Value pairs

NB: Need to check which parts of this PR need to be ported to mapr, which overrides some parts of webclient.

[will-moore]

Seems black and flake8 passed locally when creating that last commit...

(omeroweb2) LS30778:omero-web wmoore$ git commit -m "Handle AnnotationCounts with ?dataset=1&image=2"
[WARNING] Unstaged files detected.
[INFO] Stashing unstaged files to /Users/wmoore/.cache/pre-commit/patch1601029874.
[INFO] Initializing environment for https://github.com/psf/black.
[INFO] Installing environment for https://github.com/psf/black.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
black....................................................................Passed
flake8...................................................................Passed
[INFO] Restored changes from /Users/wmoore/.cache/pre-commit/patch1601029874.
[query_string_ids a5ee03581] Handle AnnotationCounts with ?dataset=1&image=2
 1 file changed, 3 insertions(+)

[joshmoore]

Seems black and flake8 passed locally when creating that last commit...

Is it possible it was only testing the changes in that one commit?

[will-moore]

Yes, I think so. I didn't have pre-commit enabled for the previous commit.

[manics]

If I select multiple images and click on the Link to this button I get https://merge-ci.openmicroscopy.org/web/webclient/?show=image-85518|image-85519|image-85523|image-85564|... Is this query format in scope for the PR, or a separate issue?

Editting map-annotations seems to be broken, both individual and batch edit.

Tagging multiple images sometimes works but there's some weird behaviour. In a dataset with >500 images:

1. Add a tag to the first image in the dataset.
2. Select 500 images including the first one. The tag appears in the right hand panel even though it's only applied to the first image:
   
3. Save. The tag is not applied to the other 499 images.
4. If instead I select just 4 images including the first, the dialog appears as expected.
   
   Adding and saving the tag applies to the selected images.

Adding and deleting a comment on 500 images works.

Select 500 images. Click the + under attachments. The Choose attachments seems to get stuck on Loading attachments. Is it perhaps running a query for each image?

Adding/removing ratings from 500 images works. Noticed an anomaly unrelated to this PR #230

Several issues here, I'm not sure which are due to this PR and which are existing issues that have only become apparent due to this PR letting you select more images than previously, so feel free to indicate what is/isn't in scope.

[jburel]

I was able to create KVP with the last commit

[pwalczysko]

http://idr.openmicroscopy.org/webclient/?show=dataset-3558 is a good candidate for testing - filtering by anything else except by name does not work - hopefully can be fixed by the present PR

[pwalczysko]

Bug: Error when annotating many images with KVP:

• go to https://merge-ci.openmicroscopy.org/web/webclient/?show=dataset-13651 and select all the images in the first page
• expand the KVP hamonica and start creating a new KVP
• observe an error dialog after you hit Enter on entering the Value
• the error dialog is empty (hard to get more info, but @will-moore is able to reproduce)

[pwalczysko]

If a KVP (or, I suspect, any annotation) is added to many objects, the tooltip is trying to list all of them, but it does not go very far, instead listing just listing one image 1 repeatedly - it is very hard to screenshot a tooltip, sorry. But this can be seen on the KVP "home" (there is no value to it), which was added to all images of https://merge-ci.openmicroscopy.org/web/webclient/?show=dataset-13651

[will-moore]

@jburel - I'd love to try and get this merged. Could you see if you're still getting the errors you reported above for the Tag dialog? Thanks.

[jburel]

The tag dialog loads but it takes time and b/c there is no feedback e.g. spinner I end up having a blank dialog for a good amount of time.
user-1 has a limited number of tags so I will need to create more tags to see the impact.
The data loading without feedback is also an issue on the right-hand panel. the General tab is blank for several seconds when numerous objects are selected

[jburel]

[exclude]

EDIT: removing flag 2022:09:12

[imagesc-bot]

This pull request has been mentioned on Image.sc Forum. There might be relevant details there:

https://forum.image.sc/t/help-needed-with-omero-tagging-system/70492/2

[imagesc-bot]

This pull request has been mentioned on Image.sc Forum. There might be relevant details there:

https://forum.image.sc/t/omeroweb-visualising-images-on-filtered-sets-for-labeling/71558/2

[will-moore]

@jburel Another example of users needing to filter larger numbers of images at https://forum.image.sc/t/omeroweb-visualising-images-on-filtered-sets-for-labeling/71558/2 which will expose the issue that this PR addresses...

Could you remove the exclude flag (or OK for me to do it)?
I'll try to reproduce the issues described above... I could/should try to address the "show loader for slow responses" issues in a separate PR, but could do that before this one if that's a blocker for testing.

[will-moore]

With this PR and ome/omero-mapr#64 deployed on merge-ci again, I've tested tagging, filtering, rating, file attachments and key-value pairs.
The only issue I saw was in the creation of Key-Value pairs for a large number of Images. If the auto-save triggers to update KVP while the initial call is still creating them, you get an error (not sure why).
I can look into that, but I would argue that it's a separate bug (due to slow saving) from the one that is being fixed in this PR (URL request strings too long).

[will-moore]

@pwalczysko @jburel OK for another round of testing, to see if there's any reproducible issues that need fixing?

[jburel]

• Spinner right hand panel #400
• Add comment on large number of objects #401
• Annotating large number of objects #402
• Large Selection and SplitView Figure #403
• Large selection of images. Download/Export action #404
• Large Selection of images: Show parent Projects and Datasets #405
• Select large number of images: Click Link icon #406
• Large selection: Show KVP #407

[will-moore]

@jburel Thanks for the testing. I'm not sure which of those issues need fixing before this PR is good to merge?

Related: I revived a PR (even older than this one!) at #17 and tried to address performance of right panel...

[pwalczysko]

Went through the RHP entirely (Tags, attachments, Comments, Ratings, download menu, link, scripts, Open With) whilst having 500 images selected today.
All was fine (on UoD network) except:

1. no downloads menu resulted in a valid window (only blank window)
2. 500 images do not open in Figure
3. the url harvested successfully (?) from the top right corner icon, when pasted into a new tab, does not bring me to the 500 images, insead it just does not bring up anything
4. Split View Figure script has a blank window (but the Thumbnail figure works as expected)

[imagesc-bot]

This pull request has been mentioned on Image.sc Forum. There might be relevant details there:

https://forum.image.sc/t/autotagging-does-not-work-with-plates/73721/5

[will-moore]

• Spinner right hand panel #400 is fixed by Right panel spinner #423
• Add comment on large number of objects #401 addressed by Show spinner while loading and saving Comments #426
• Annotating large number of objects #402 also addressed by Show spinner while loading and saving Comments #426
• ... more to come...

[jburel]

Excluding this PR ahead of the dependencies upgrade work
--exclude