-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add whitenoise as a dependency #397
Conversation
Just adding
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
👍 Thanks, @jburel. Guess the only questions are if there are any other dangling deps like this and if we know why it had such a special status. |
The only one that could be included is |
That seems more clearly like an add-on. |
agree |
Suggesting to push a tag: 5.16.0 since we have a dependency injection |
👍 |
As per the dependency argument, would #415 also be a candidate for 5.16.0? |
It makes sense |
See ome/omero-documentation#2270 for background discussion
If the proposed change is merged. The installation documentation will need to be adjusted