Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable submit and show spinner while editing channels #398

Merged
merged 2 commits into from
Sep 15, 2022

Conversation

will-moore
Copy link
Member

Fixes #304.

There were 2 problems with channel editing previously:

To test:

  • Edit channel names (either a single image or multiple Images in a Dataset or Plate)
  • On clicking 'Save' or 'Confirm', the button will be disabled and show a spinner while saving to server.
  • Clicking twice shouldn't submit more than once (can check the Network tab in dev tools to confirm)
  • Cancel will reset the form.

@will-moore will-moore marked this pull request as ready for review September 13, 2022 08:36
@pwalczysko
Copy link
Member

Works as expected. Maybe remove the Cancel button, as it does not cancel anything.

@pwalczysko
Copy link
Member

Cancel button is hidden, the functionality is working as expected. Ready to merge fmpov.

@jburel jburel merged commit a50b465 into ome:master Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

edit channel names deadlock PSQLException
3 participants