Expand description of default_user and default_group search configurations #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tions Specify the expectations when setting the special values of 0 (default) and -1
|
It will make sense to also include this PR in the upcoming release. This is only doc for properties. |
pwalczysko
reviewed
Jan 10, 2023
pwalczysko
requested changes
Jan 10, 2023
Co-authored-by: pwalczysko <p.walczysko@dundee.ac.uk>
|
@pwalczysko's suggestion has been integrated. Merging the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarify the expectations when setting the special values of 0 (default) and -1 for the
omero.web.search.default_userandomero.web.search.default_groupproperties introduced in #297Additionally, this reveals a lack of symmetry between default user where
0==current userand-1==all users/membersand the default group where both0and-1are all groups. I assume in an upcoming breaking change, the logic could be reviewed so that0could select the current group./cc @muhanadz @knabar