OMERO.web:test login requests with JSON #6420
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the expected response message to include the reason Add a second integration test with a X-CSRFToken with empty value
Test empty and invalid CRSF token scenarios
Add test for missing CSRF cookie, empty and invalid CSRF tokens
knabar
approved these changes
Feb 18, 2025
| login_json = json.loads(login_rsp.content) | ||
| assert login_json['success'] | ||
| event_context = login_json['eventContext'] | ||
| login_rsp = django_client.post( |
There was a problem hiding this comment.
Mostly comment to myself - this works because Client.post() encodes the passed-in data according to the given content_type for application/json and MULTIPART_CONTENT; all other content_types would cause data to be passed as is.
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on the improvements in ome/omero-web#607
This PR builds on top of #6419 to benefit from the refactoring and reduce conflicts as unnecessary imports are removed. Both
test_login_errorsandtest_login_exampleare updated to test a login request posted either as form data or as JSON