-
-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Some tokenizer as language module #1186
chore: Some tokenizer as language module #1186
Conversation
50fac34
to
3ce1c96
Compare
❌ Quality checks failed. Please look a Gradle Scan page for details: |
❌ Acceptance Tests failed. Please look a Gradle Scan page for details: |
❌ Acceptance Tests failed. Please look a Gradle Scan page for details: |
❌ Quality checks failed. Please look a Gradle Scan page for details: |
There is no obvious benefit to move tokenizer classes to language-module and change package paths. Most tokenizers come from Lucene-analyzer-common library that is a mandatory library of OmegaT core. There are three languages that can be justificated for the change; Japanese, Chinese and Polish that are provided their special analyzer. |
Signed-off-by: Hiroshi Miura <miurahr@linux.com>
e4b94c2
to
3492567
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Signed-off-by: Hiroshi Miura <miurahr@linux.com>
❌ Quality checks failed. Please look a Gradle Scan page for details: |
❌ Acceptance Tests failed. Please look a Gradle Scan page for details: |
This is not feasible to split tokenizer to module. I want to give up here. |
Tokenizer is used for the project in which the source or target language is the same as the provided one.
It is feasible to move tokenizers to the corresponding language module.
Pull request type
Which ticket is resolved?
What does this PR change?
Other information
Depends on #1183