-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ephemeral CI run API #80
base: main
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## main #80 +/- ##
==========================================
- Coverage 41.13% 40.88% -0.25%
==========================================
Files 25 25
Lines 6681 6746 +65
==========================================
+ Hits 2748 2758 +10
- Misses 3676 3728 +52
- Partials 257 260 +3
Continue to review full report at Codecov.
|
var problemFiles *common.ProblemFiles | ||
|
||
if report.IsEphemeral { | ||
r.ParseMultipartForm((base.Byte(150) * base.Mebibyte).Bytes()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
todo
poner estos en un lugar más mono, pero no sé donde 🙃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
esto va a timeoutear bien recio :/ tenemos problemas para subir zips grandes, así que esto va a estar súper flaky.
además que andar mandando zips de más de 100 MiB nos va a salir bastante caro ^^;; así que realísticamente sólo podríamos permitir como uno de estos por minuto, lo cual suena medio inútil para fines de CI.
La idea es poder llamar a
omegaup.com/grader/ci/ephemeral/
con tu zip feliz y pues usar lo que ya está para que conteste. Elreport.json
basta, y pues si no entiendo mal como son ephemeral runs podrías hacerles browse con tu navegador, no? (Que eso lo extraño mil deomegaUp-deploy v1
)Faltan tests, soporte de output generation, algún tipo de rate limiting—probablemente basta con pedir API token y llamar al frontend para contar, no?
Como quiera, quejas, comentarios o sugerencias 👀