Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

view.sort-selector filter argument mismatch in 4.0 #1994

Closed
zerocrates opened this issue Jan 30, 2023 · 0 comments · Fixed by #1995
Closed

view.sort-selector filter argument mismatch in 4.0 #1994

zerocrates opened this issue Jan 30, 2023 · 0 comments · Fixed by #1995
Assignees

Comments

@zerocrates
Copy link
Member

The view.sort-select filter used in the Browse and SortSelector helpers don't take the same arguments.

The legacy sortSelector takes sortBy, an array with keyed contents for label and value, while the new browse helper takes sortConfig, a one-level key => value array of the options and labels.

One of these needs adjusting so it's the same as the other so modules can have a single sort-selector filter implementation regardless of the helper being used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants