Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resource page block default config for media doesn't include showing the media #2058

Closed
zerocrates opened this issue Jun 1, 2023 · 0 comments
Closed

Resource page block default config for media doesn't include showing the media #2058

zerocrates opened this issue Jun 1, 2023 · 0 comments
Assignees
@jimsafley @zerocrates @kimisgold

Comments

@zerocrates
Copy link
Member

zerocrates commented Jun 1, 2023 •
edited
Loading

Default config for the media page main region is just values, and should include mediaRender as the first item instead.

This looks like it was an oversight that occurred when the mediaRender block was introduced in b951a29: the default render call was removed from the media show, but mediaRender wasn't added to the default media-page config.

A parallel issue exists in... probably all themes: we could cross-reference those to this issue to track updates for them.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jimsafley jimsafley

@zerocrates zerocrates

@kimisgold kimisgold

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jimsafley @zerocrates @kimisgold