Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick fixes for translations #1396

Merged
merged 3 commits into from
Apr 10, 2019

Conversation

ManOnDaMoon
Copy link
Contributor

Hello,

A quick PR for fixing 2 missing translation tags:

  • in site settings page, the "Restrict to templates" label was not marked for translation
  • in search filters view helper, the resource class label was not translated

Thank you in advance and have a nice day

Laurent

@ManOnDaMoon
Copy link
Contributor Author

A quick explanation about a07b693: the distinction between login and log in is a bit stronger in some languages than in english. Especially on the login page, having 'Login' as the title is like displaying 'A login' instead of requesting to sign in to the application. The verb form will be less ambiguous here.

@ManOnDaMoon ManOnDaMoon changed the title Quick fixes for missing translations Quick fixes for translations Apr 10, 2019
@zerocrates zerocrates merged commit c695542 into omeka:develop Apr 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants