Fixed GD thumbnailing of an image with an icc profile. #1421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So this just copies over the ICC profile from the input to the output; it's not doing any actual color conversion, correct? |
|
yes, it's a simple copy of the profile. You may find another way to extract/copy the profile, but the library works well. |
|
You can try with such an image : https://i.stack.imgur.com/p42W6.jpg |
|
Maybe a conversion may be a better way, but often unperfect. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an image has an icc profile and gd is used, colors are no kept. This pr fixes it.
The issue may be the same for imagick, but it depends on the version. A fix for it can be done too, like in Daniel-KM/LibraryDeepzoom#1.