Returned an array when fetching all values when there is no result. #1489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This can probably go into a version 3 without issue... otherwise I'd be slightly concerned about the backwards incompatibility. |
|
All pull requests I sent are on my dev server, a demo server. They works fine with all my modules and other ones that I use. I didn't check other modules. For this commit, generally the check is ! or empty(), so there is no issue. |
Daniel-KM
pushed a commit
to Daniel-KM/Omeka-S
that referenced
this pull request
Mar 9, 2020
Returned an array when fetching all values when there is no result.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is more logic and avoids to check the result when all values are wanted (can be used directly by foreach without setting default).