-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved resource templates to manage settings (Laminas) #1609
Closed
Daniel-KM
wants to merge
51
commits into
omeka:develop
from
Daniel-KM:feature/resource_template_settings_3
Closed
Improved resource templates to manage settings (Laminas) #1609
Daniel-KM
wants to merge
51
commits into
omeka:develop
from
Daniel-KM:feature/resource_template_settings_3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ource template properties.
This was referenced Aug 28, 2020
Closed
Daniel-KM
force-pushed
the
feature/resource_template_settings_3
branch
from
August 28, 2020 18:59
db4e23d
to
9acd21a
Compare
Rebased directly on develop in #1614. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #1597, it's a next step to manage resource template improvements (#1565).
In fact, I need to know if you will merge this pr or not. Of course, the core should not have all features, in particular when they can be provided by a module. But to manage multiple data types by property cannot be done in a module and, for this pr, to manage settings in the core will allow to manage many settings in the modules, like #1610 that allows to display a limited list of languages for the values, that will help users.