Multiple data types by property in form #1634
Conversation
Daniel-KM
force-pushed
the
feature/template_datatypes_multiple
branch
from
10c5d7a
to
9f534c3
Compare
|
|
||
| $sql = <<<SQL | ||
| UPDATE `resource_template_property` | ||
| SET `data_type` = CONCAT('["', REPLACE(TRIM(`data_type`), "\n", '","'), '"]') |
There was a problem hiding this comment.
Quick question here: the handling of newlines and multiple values, that's accounting for a previous version of this that stored the multiple values that way?
I'd imagine we could leave that, and therefore the whole REPLACE out, yeah? And for that matter the check for [ in the WHERE?
Anybody who's been on an intermediate version of one of these could just throw this migration id in the migrations table and skip it.
There was a problem hiding this comment.
Yes, it is related to an old version. I removed it.
|
I believe the initial version of this had changes to import/export, which are now gone. Is that being separated out or what? It's fine to be in this PR along with the rest of what's here. If I've just caught you in between changes, that's fine also. |
Daniel-KM
force-pushed
the
feature/template_datatypes_multiple
branch
from
9f534c3
to
dc11c44
Compare
|
I saw that there was the import view that was remaining, but not the controller part. So I rebased and now there is the whole import/export part. |
|
Thanks for bearing with us on all those change requests. |
This is the single feature to manage multiple data types in resource template (see #1614).