Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support text/json+oembed (Soundclound) #1670

Merged
merged 1 commit into from
Nov 30, 2020
Merged

Conversation

Avnerus
Copy link
Contributor

@Avnerus Avnerus commented Nov 25, 2020

Hi,
I tried to embed a Soundcloud link and the the oEmbed directive was not found.
I noticed that they use the typetext/json+oembed instead of application/json+oembed.
After applying the following fix, Soundcloud embedding works.

/Avner

@zerocrates
Copy link
Member

I assume there's no chance of Soundcloud changing things on their end...

It's a little annoying to be dealing with a very short spec like oEmbed that specifically says

The type attribute must contain either application/json+oembed for JSON responses, or text/xml+oembed for XML.

but to encounter something like this anyway.

@zerocrates zerocrates merged commit 15280b5 into omeka:develop Nov 30, 2020
@zerocrates
Copy link
Member

On the other hand we already accept link rel "alternative" here so I suppose there's no need to stand on strict correctness and I can't see it harming anything, so I merged it.

Thanks for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants