Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some typos (most of them found by codespell) #1794

Merged
merged 1 commit into from
Jan 26, 2022

Conversation

stweil
Copy link
Contributor

@stweil stweil commented Dec 22, 2021

Signed-off-by: Stefan Weil sw@weilnetz.de

@stweil
Copy link
Contributor Author

stweil commented Jan 26, 2022

Ping?

@zerocrates
Copy link
Member

zerocrates commented Jan 26, 2022

Ah yes, sorry. I thought I'd responded to this before.

I think this mostly looks good... who knew we had so many typos in comments. One note: "invokable" is the Zend/Laminas terminology/spelling when we're using it in comments and code, so we won't want to change that to "invocable."

@stweil
Copy link
Contributor Author

stweil commented Jan 26, 2022

I removed the changes for "invocable" now from the pull request.

@stweil
Copy link
Contributor Author

stweil commented Jan 26, 2022

who knew we had so many typos in comments

That's normal for projects which never used a spell checker like codespell before, so no reason to be worried. :-)

@zerocrates
Copy link
Member

Thanks.

Oh and sorry, I forgot to mention... I don't know what the situation is with the RDF/XML/OWL files in the application/data/vocabularies folder... those are externally-sourced standardized files and we probably don't want to be fixing their typos unilaterally. Probably best to remove those also.

@stweil
Copy link
Contributor Author

stweil commented Jan 26, 2022

application/data/vocabularies is now removed from the pull request.

@stweil
Copy link
Contributor Author

stweil commented Jan 26, 2022

The string "A foaf:LabelProperty is any RDF property with texual values that serve as " comes from application/data/vocabularies, but is translated in application/language, so I think it has to be reverted there, too.

@stweil
Copy link
Contributor Author

stweil commented Jan 26, 2022

I think it has to be reverted there, too.

Done now. I had to remove some more changes which were related to application/data/vocabularies.

Signed-off-by: Stefan Weil <sw@weilnetz.de>
@zerocrates
Copy link
Member

Thanks for making those changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants