Fixed doctrine deprecation warning for using UnderscoreNamingStrategy without making it number aware. #1804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… without making it number aware.
|
Huh, the deprecation notice is there in the Doctrine we have but it's silenced with I wonder if you picked up a newer Doctrine somewhere that actually throws this in a way it can be seen. That would square with the build system problems we saw on your other PR that modified the composer.json. Either that or you have something like XDebug's "scream" on. Anyway the current locked version also takes this argument and just silently complains about it being missing, so I see no issue taking this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.