Fix/value annotation resource #1997
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(fix omeka#1657) (cherry picked from commit 4aeca55)
(fix omeka#1659) (cherry picked from commit 384af74)
(cherry picked from commit 7600c9f)
(cherry picked from commit b48976e)
Since we use it fairly extensively in the internals, we need to check for its presence more or less immediately to avoid just having a fatal PHP error instead. (cherry picked from commit 2a76cf2)
(cherry picked from commit da1a732)
Co-authored-by: Daniel Berthereau <Daniel.git@Berthereau.net> (cherry picked from commit c1172b7)
(cherry picked from commit 38de23b)
(cherry picked from commit 9f8c338)
(cherry picked from commit e156a5b)
(cherry picked from commit ce8c1f5)
(cherry picked from commit 7cf6b87)
(fix omeka#1680) (cherry picked from commit dfbab69)
(cherry picked from commit 998e7af)
(cherry picked from commit 2c1cb43)
(fix omeka#1685) (cherry picked from commit ca4052c)
(omeka#1688) (cherry picked from commit 442e395)
The detach process used in batch edit/create is pretty brittle, especially in "synchronous" or in-process contexts where many more entities are loaded before the batch edit begins, so the results are less predictable. Typical "bad" results are Doctrine errors about duplicates or encountering "new" un-persisted entities through a relationship. The detach also serves very little purpose in this context, as it's only there to improve performance _between_ multiple batches, and the in-process edits only do a single batch. This commit adds a new request option for batch edits and creates, "detachEntity", defaulted to true, and has the controllers for the in-process batch updates set it to false. (omeka#1690) (cherry picked from commit 578dd20)
(cherry picked from commit e556729)
(cherry picked from commit d87e21c)
(cherry picked from commit b2b4979)
(fix omeka#1698) (cherry picked from commit 05ac39a)
(cherry picked from commit 2866f03)
(cherry picked from commit 9b1389e)
Version 3.1.0
(cherry picked from commit 284f4f4)
(cherry picked from commit 5dece9e)
(cherry picked from commit 5c9694b)
…ction. (cherry picked from commit d0051ba)
(omeka#1678 again) (cherry picked from commit 0c93db0)
(omeka#1844) (cherry picked from commit ca8135a)
(cherry picked from commit 82dea04)
We used to use "mpeg" which was the name of the ImageMagick coder being used, but they've changed it to "video." "mp4" is supported by both old and new versions. (fix omeka#1841) (cherry picked from commit dc9fe51)
Revoke misleading user create/batch privileges. (fix omeka#1856) (cherry picked from commit 71c2d6c)
(fix omeka#1857) (cherry picked from commit a5f5142)
(cherry picked from commit 78a02889e97ec082c0879142177ca911726225d4)
(cherry picked from commit 613c45c)
…verse (fix omeka#1878) (cherry picked from commit abecce6)
(cherry picked from commit f1b5cc0)
We use this with the external IM thumbnailer, and the Imagick equivalent exists (but it's poorly/non documented). Using flatten is linked to unwanted inverted-color output when given CMYK input on some servers. (cherry picked from commit 6d1c4c1)
Daniel-KM
force-pushed
the
fix/value_annotation_resource
branch
2 times, most recently
from
31511fb
to
c923506
Compare
|
Sorry, the commit was passed against master instead of develop and I can't change it here. |
|
Probably best to just make a new PR against develop with the single commit at issue here, and we'll close this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The resource value annotations use the same template than resource values, so it should pass the resource too.
By the way, there is an important missing feature about value annotation : there is no template, so the user should select the properties and the datatype one by one. Most of the time, it's only one or two properties, but it should be listed somewhere, so it can be filled in one click.
So is it better I improve the module Advanced Resource Template for that or to push request here to avoid a future re-implementation, because it is probably something people will want later.
As for many other things, is there a way to know what will be inside the core and what will remain in the modules to avoid to develop the same thing multiple times with subtle variants?