Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added an event to get linked resources via subject values. #2054

Merged
merged 2 commits into from
Jun 12, 2023

Conversation

Daniel-KM
Copy link
Contributor

Some people want to order subject values not by title, but by something else, for example by bibo:volume and bibo:issue. The feature is already implemented in module Advanced Resource Template, but an event is needed for that.

@jimsafley
Copy link
Member

Thanks for this. I can see this being helpful.

I see that you're differentiating the events by an isSimple argument. We prefer that you use distinct names instead: api.subject_values.query and api.subject_values_simple.query.

@Daniel-KM
Copy link
Contributor Author

Ok.

@Daniel-KM Daniel-KM force-pushed the feature/trigger_subjectvalues branch from a077c18 to 7a1a566 Compare June 2, 2023 20:22
@zerocrates
Copy link
Member

Thanks.

@zerocrates zerocrates merged commit 65f8525 into omeka:develop Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants