Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/site from item set #2057

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

Daniel-KM
Copy link
Contributor

In item resource form, it is possible to assign sites, but not in item set resource form. So this feature is added here, and subsequent implications (display sites in item set view, define a user setting for item sets.

There is a last point that is not managed: to add or not to add a site option to assign item sets to it, like it exists for items. For now, the process use the same key "assign_new_items" to manage process. In fact, there are three possibilities:

  • use one column in table site, so rename assign_new_items to and assign_new_resources.
  • let existing column and change its meaning (like in this pr).
  • let existing column in table site and use a site setting to manage the option for item set.
  • use two columns in table site: assign_new_items and assign_new_item_sets.

So the point is should we manage items and item sets options separately or not? The same for acl.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant