Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In item resource form, it is possible to assign sites, but not in item set resource form. So this feature is added here, and subsequent implications (display sites in item set view, define a user setting for item sets.
There is a last point that is not managed: to add or not to add a site option to assign item sets to it, like it exists for items. For now, the process use the same key "assign_new_items" to manage process. In fact, there are three possibilities:
site
, so renameassign_new_items
to andassign_new_resources
.site
and use a site setting to manage the option for item set.site
:assign_new_items
andassign_new_item_sets
.So the point is should we manage items and item sets options separately or not? The same for acl.