Fix warnings in the to_string functions of QoSes & reducing timeout o…

…f interoperability_report.py (#9) * Fix warnings in the to_string functions of QoSes * Reducing the timeout to improve performance in GitHub actions
omg-dds · Mar 21, 2023 · c6b8f93 · c6b8f93
1 parent 0d8fdab
commit c6b8f93
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/interoperability_report.py b/interoperability_report.py
@@ -686,7 +686,7 @@ def main():
     # applications. A TestSuite contains a collection of TestCases.
     suite = junitparser.TestSuite(f"{name_publisher}---{name_subscriber}")
 
-    timeout = 10
+    timeout = 5
     now = datetime.now()
 
     t_suite_module = importlib.import_module(options['test_suite'])

diff --git a/srcCxx/shape_main.cxx b/srcCxx/shape_main.cxx
@@ -77,6 +77,7 @@ class QosUtils {
         } else if (reliability_value == RELIABLE_RELIABILITY_QOS){
             return "RELIABLE";
         }
+        return "Error stringifying Reliability kind.";
     }
 
     static std::string to_string(DurabilityQosPolicyKind durability_value)
@@ -90,6 +91,7 @@ class QosUtils {
         } else if (durability_value == PERSISTENT_DURABILITY_QOS){
             return "PERSISTENT";
         }
+        return "Error stringifying Durability kind.";
     }
 
     static std::string to_string(DataRepresentationId_t data_representation_value)
@@ -99,6 +101,7 @@ class QosUtils {
         } else if (data_representation_value == XCDR2_DATA_REPRESENTATION){
             return "XCDR2";
         }
+        return "Error stringifying DataRepresentation.";
     }
 
     static std::string to_string(Verbosity verbosity_value)
@@ -116,6 +119,7 @@ class QosUtils {
         default:
             break;
         }
+        return "Error stringifying verbosity.";
     }
 
     static std::string to_string(OwnershipQosPolicyKind ownership_kind_value)
@@ -125,6 +129,7 @@ class QosUtils {
         } else if (ownership_kind_value == EXCLUSIVE_OWNERSHIP_QOS){
             return "EXCLUSIVE";
         }
+        return "Error stringifying Ownership kind.";
     }
 
     static std::string to_string(HistoryQosPolicyKind history_kind_value)
@@ -134,6 +139,7 @@ class QosUtils {
         } else if (history_kind_value == KEEP_LAST_HISTORY_QOS){
             return "KEEP_LAST";
         }
+        return "Error stringifying History kind.";
     }
 };