This repository has been archived by the owner on Dec 5, 2021. It is now read-only.
[LP_swaps] feat: return funds for unfulfillable swap #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CAPtheorem
added a commit
that referenced
this pull request
Jun 8, 2021
* Merge omgx_contracts into /optimism monorepo; integrate message-relayer-fast; and connect up message-relayer-fast with the Dockers/ops * further cleanup * get address from addressManager; add tests for the message-relayer-fast * testing contract deployments to the new stack * Deployment working.... * Add fast and slow message contracts (#38) * wip - simplify system - remove message-relayer-fast * Update L1LiquidityPool.sol * message relay working * almost there * major wallet functions confirmed working - ready * fix integration tests * minor tweaks to get everything to run on rebased develop branch * Integrate #37, confirm compilation and function * update .env.example for stable rinkeby endpoint * adds the message-relayer-fast - goal is to end up with self contained folder for this service and associated tests * Added whitelist (#44) * wip - disable npm publish until that's set up * Update publish-develop.yml * fix formatting via yarn run lint:fix * more lint cleanup * assorted and sundry linting issues * final lint/GH/yarn actions fixes * remove unneeded spreadsheet code * fix truffle networkID and more linting * Updated addresses (#45) * update fraud-prover .env and accomodate L2 fee = enabled * Update addresses.json * fixes tslint<>prettier clash which breaks the GH actions * delete deployment files Co-authored-by: cby3149 <46272347+cby3149@users.noreply.github.com> Co-authored-by: cby3149 <cby3149@outlook.com>
CAPtheorem
added a commit
that referenced
this pull request
Jun 10, 2021
* Merge omgx_contracts into /optimism monorepo; integrate message-relayer-fast; and connect up message-relayer-fast with the Dockers/ops * further cleanup * get address from addressManager; add tests for the message-relayer-fast * testing contract deployments to the new stack * Deployment working.... * Add fast and slow message contracts (#38) * wip - simplify system - remove message-relayer-fast * Update L1LiquidityPool.sol * message relay working * almost there * major wallet functions confirmed working - ready * fix integration tests * minor tweaks to get everything to run on rebased develop branch * Integrate #37, confirm compilation and function * update .env.example for stable rinkeby endpoint * adds the message-relayer-fast - goal is to end up with self contained folder for this service and associated tests * Added whitelist (#44) * beginning of a fast relayer with unit tests * basics are working * feat: modify tests to add custom messenger * feat: make messenger address pluggable * feat: depl local * feat: register custom messenger * feat: automate * feat: automate * feat: add options for using own custom messegner with service * feat: add options for using own custom messegner with service * merge master * rem: dep files * chore: change build command * style: rename all vars to _fast Co-authored-by: CAPtheorem <79423264+CAPtheorem@users.noreply.github.com> Co-authored-by: cby3149 <46272347+cby3149@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
fast exit for amounts higher than pool size (or) pool doesn't have enough funds remaining (or) atomicity races - would block the exitor's funds until the enough liquidity point on the other side is reached
Changes
This reverts and returns funds to the exitor, if the swap request is unfulfillable