add apple pay integration #312
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyler-techcombine
requested review from
rosle,
jutinapas,
Narum11,
hpariwat,
FhanOmise,
new4762 and
AnasNaouchi
AnasNaouchi
reviewed
Feb 26, 2025
AnasNaouchi
reviewed
Feb 26, 2025
OmiseSDK/Sources/Views/Screens/Choose Payment Methods/ChoosePaymentCoordinator.swift
Show resolved
Hide resolved
AnasNaouchi
reviewed
Feb 26, 2025
...es/Views/Screens/Choose Payment Methods/Other Payments/ApplePay/ApplePayViewController.swift
Outdated
Show resolved
Hide resolved
AnasNaouchi
reviewed
Feb 26, 2025
...urces/Views/Screens/Choose Payment Methods/Other Payments/ApplePay/ApplePaymentHandler.swift
Outdated
Show resolved
Hide resolved
AnasNaouchi
previously approved these changes
Feb 27, 2025
rosle
previously approved these changes
Feb 27, 2025
Narum11
previously approved these changes
Feb 28, 2025
new4762
previously approved these changes
Feb 28, 2025
tyler-techcombine
dismissed stale reviews from new4762, Narum11, and rosle
via
4115996
tyler-techcombine
force-pushed
the
feature/apple-pay-integration
branch
from
fe8b33b to
4115996
Compare
AnasNaouchi
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Integrates Apple Pay support into the Omise iOS SDK by introducing a new
ApplePaymentHandlerto manage the complete payment flow usingPKPaymentAuthorizationController, along with anApplePayViewModelthat encapsulates the payment logic and token payload creation. The implementation uses dependency injection and protocol abstraction for easy testing and mocking, requests billing contact details when needed, and handles errors gracefully to ensure a seamless payment experience with minimal external code changes.Demo
with-add.MP4