Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Prevent retrieve authentication while module was not configured or key not added yet #189

Closed
tuyennn opened this issue May 6, 2019 · 3 comments
Closed

[BUG] Prevent retrieve authentication while module was not configured or key not added yet #189

tuyennn opened this issue May 6, 2019 · 3 comments

Comments

@tuyennn
Copy link

tuyennn commented May 6, 2019 •
edited
Loading

Steps to reproduce

  • Magento 2.2.7
  • Fresh install module
  • Payment was not configured or added any key

Expected result

  • From checkout or every constructor class will not call retrieve or authentication data or anything else, unless the module enabled(key added)

Actual result

  • Got Exception on some __construct while the authentication was called but module was not used(key not added)

image

image
@jacstn
Copy link
Contributor

jacstn commented May 8, 2019

ok, thank you for your bug report.
Will investigate and fix it asap.

@tuyennn
Copy link
Author

tuyennn commented Jun 4, 2019

@jacstn what is the status of this issue? I have to temporary disable your payment gateway on all our development, staging environments.

@jacstn jacstn mentioned this issue Sep 2, 2019
Merged
@jacstn
Copy link
Contributor

jacstn commented Sep 6, 2019

fixed.

@jacstn jacstn closed this as completed Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tuyennn @jacstn