Handle exception when getting capabilities with invalid Omise Keys #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonrandy
reviewed
Sep 2, 2019
Model/Api/Capabilities.php
Outdated
| @@ -8,9 +8,13 @@ class Capabilities extends BaseObject | |||
| { | |||
| private $capabilities; | |||
|
|
|||
| public function __construct() | |||
| public function __construct(\PSR\Log\LoggerInterface $log) | |||
jonrandy
approved these changes
Sep 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Objective
This fixes unhandled exception when omise keys are wrong or not set in the admin panel.
Related information:
Related issue(s): #189
2. Description of change
Added
try/catchwhen getting capabilities.Return particular capabilities only if the capabilities API object is not null.
3. Quality assurance
🔧 Environments:
✏️ Details:
Remove omise keys, make sure application does not crash when going to the checkout page.
4. Impact of the change
N/A
5. Priority of change
Normal
6. Additional Notes
N/A