MAG2: Removed unused files #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Objective
There is an error
Class Omise\Payment\Model\Configdoes not exist when executesetup:di:compilecommand which occurred because some unused files are still referring to that class (thatOmise\Payment\Model\Configclass has been removed since a while but there are still some files that refer to that class).Related information:
Related issue(s): #84
2. Description of change
Just removed unused files so those will not be included when
setup:di:compileis executed3. Quality assurance
🔧 Environments:
✏️ Details:
From the issue #84, if you try execute
setup:di:compilecommand this time, it won't show any errors.4. Impact of the change
None.
5. Priority of change
Normal
6. Additional Notes
None.