Switches on 'showInStore' for all config options to allow full multi-store functionality #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jonrandy can you provide a screenshot of, 'what the setting page looks like' with and without these change? |
|
@guzzilar Did I do that right? |
|
@jonrandy Uhmm.. probably no. Just |
|
I thought that's what I did. A drag and drop rebase in Gitkraken. All the stuff seems to be there now |
|
Done? |
…store functionality Also addes store_id and store_name to metadata in the Charge object
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Objective
Make sure all config settings for Omise Magento are available down to the store level - to facilitate full multistore capability. Also add some details about the current store in the charge metadata
2. Description of change
adminhtml/system.xmlmodified to turn on allshowInStoreswitches.paymentdatabuilder.phpmodified to add store info to charge metadata3. Quality assurance
I set up a sample site with multiple stores and views, and different Omise Magento settings for each store view. I then made an order from each store view, checking that the payment options were correct for each view, and that the correct store info had been added to the charge metadata in each case
4. Impact of the change
No visible changes will be seen when this update is installed unless installed on a site that has multiple stores/views - in which case the merchant will have control over the plugin on a per store basis
👆 When you select any 'scope' after the update, the Omise options will be available for changing. They were only available at the top level before
5. Priority of change
Normal
6. Additional Notes
It's not raining today, but wow is it hot! 🔥