Removes link/dependency with Authorize.net module #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Objective
Remove a small link/dependency with the
authorize.netmodule. It's risky leaving it there as we cannot guarantee the module will be present. This makes our module more self contained2. Description of change
Add a new class within our module to handle the
PaymentActiondropdown for credit cards in the admin area (copied from the similar class in Authorize.net)3. Quality assurance
Go to the magento admin area and check the dropdown mentioned above is still functioning correctly
4. Impact of the change
No noticeable change for users
5. Priority of change
Normal
6. Additional Notes
What causes thunder anyway?