Instalment Payment Option Implementation #148
Conversation
…into 2-installment
…ticular method. Removed unused debug First Choice capabilities - add list of terms
…unused declaration
…rs - visible only if order is NOT THB
jacstn
force-pushed
the
2-installment
branch
from
e5e863c to
7374513
Compare
…ed html labels added comment to function fixed labels
jacstn
force-pushed
the
2-installment
branch
2 times, most recently
from
4b6150a to
bec17ea
Compare
There was a problem hiding this comment.
Just a few small things remaining to fix. I'm also not comfortable with the amount of hardcoded stuff given that all the information to remove this is already present in the Capabilities API response, but for this first release I guess we can let most of that slide to the next release
view/frontend/web/js/view/payment/method-renderer/omise-offsite-installment-method.js
Outdated
Show resolved
Hide resolved
view/frontend/web/js/view/payment/method-renderer/omise-offsite-installment-method.js
Show resolved
Hide resolved
view/frontend/web/template/payment/offsite-installment-form.html
Outdated
Show resolved
Hide resolved
jacstn
force-pushed
the
2-installment
branch
5 times, most recently
from
bd14ab3 to
c17d96c
Compare
…lities::retrieveInstallmentBackends added to composer requirement, about newer omise-php library
| use Omise\Payment\Model\Capabilities; | ||
| use Omise\Payment\Model\Config\Installment as OmiseInstallmentConfig; | ||
|
|
||
| class CapabilitiesConfigProvider implements ConfigProviderInterface |
There was a problem hiding this comment.
So since this class is providing configs specifically for Installment, should we rename this one to just InstallmentConfigProvider?
There was a problem hiding this comment.
not sure...
Capabilities, we provide here capabilities for all payment methods in the future?
| foreach ($listOfActivePaymentMethods as $method) { | ||
| if ($method->getCode() === OmiseInstallmentConfig::CODE) { | ||
| return [ | ||
| 'installment_backends' => $this->capabilities->retrieveInstallmentBackends() |
There was a problem hiding this comment.
just want to note it out that we are sending out 3 unnecessary properties. From Capabilities API response,
{
"installment_bay": {
"type": "installment",
"currencies": [
"thb"
],
"allowed_installment_terms": [
3,
4,
6,
9,
10
],
"amount": {
"min": 2000,
"max": 100000000
}
}
}In this pull request, it uses only allowed_installment_terms and _id (special attribute generated by Omise-PHP).
We don't use type, currencies, and amount at the moment.
Would be nice if we limit an access to only what we will use in the frontend.
There was a problem hiding this comment.
will use them in the future... when we will have correct values in amount.
than I will also use currencies, now, it is also hardcoded.
jacstn
added
status: Ready
status: Released
and removed
status: Review needed
status: Ready
labels
Instalment Payment Integration.
1. Objective
Introduce Installment Payment Option in Magento 2 plugin.
2. Description of change
Added support for Installment Payments.
Key notes:
JavaScriptpayment rendering file as 5000 THB, if minimum order is not met than plugin behave in the same way as it is in situation when user choose different payment currency than THBOmise Backendwill support sending cancellation event.pendingpayment and cart is cleared byMagento, in that case user need to re-do shopping.offsite-internetbanking.csshad definitions of styles used in checkout internet banking payment method. Renamed file to generalstyle.cssand extended styles for supporting displaying installment payment method.CCConfigProvider.phpfile/class to more genericOmiseConfigProvider.phpas included alsoomise capabilitiesobject.Display message when 5000 THB value of order is not met.
3. Quality assurance
🔧 Environments:
✏️ Details:
To properly test it make successful payment with Installment Option and Credit Card Payment Method.
4. Impact of the change
N/A
5. Priority of change
High
6. Additional Notes
This PR requires omise/omise-php#99 to be merged first.
This PR requires new version of
omise-phplibrary to be released with aboveCapabilitiesPR