MAG2x: Changing long array syntax to the short syntax one. #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonrandy
reviewed
Sep 18, 2018
| ]; | ||
| } | ||
|
|
||
| return [ self::CARD => $method->getAdditionalInformation(CreditCardDataObserver::TOKEN) ]; |
There was a problem hiding this comment.
Probably clearer to use if ... else, or better still a single return with a conditional operator
jonrandy
reviewed
Sep 18, 2018
| @@ -98,7 +98,7 @@ public function reload() | |||
| class MockOmiseObject implements \ArrayAccess | |||
| { | |||
| // Store the attributes of the object. | |||
| protected $_values = array(); | |||
| protected $_values = []; | |||
There was a problem hiding this comment.
Protected var name starting with _
There was a problem hiding this comment.
@jonrandy Thanks
Code-refactoring PR will be coming in soon!
There was a problem hiding this comment.
@guzzilar no necessary to change in pr only few places.. I propose to change all in entire plugin..
There was a problem hiding this comment.
@Jacekstan yup, so changing entire plugin will be coming in an another pull request once tesco-lotus feature is merged (or maybe before) (I updated array syntax & opened this pull request just to continue from a conversation at the previous PR #123)
According to Magento Extension Quality Program Coding Standard (https://github.com/magento/marketplace-eqp). All long-array-syntax are encouraged to be updated to the short syntax one.
guzzilar
force-pushed
the
update-array-syntax
branch
from
be1a2e9 to
1087aa5
Compare
jacstn
approved these changes
Sep 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Objective
There are code standard provided by Magento that all extensions have to follow in order to submit the code to their Magento Marketplace.
This pull request is aiming to update one of the standard (array syntax) to a proper one that Magento requires.
2. Description of change
3. Quality assurance
vendor/bin/phpcs /path/to/your/extension --standard=MEQP2.Short array syntax must be used to define arrays.Before change, we should see these ones
After change, we should see none of them
4. Impact of the change
Nothing in a user perspective, but it will make our extension be able to pass the Magento Code Quality Standard and able to submit to the Magento Marketplace.
5. Priority of change
Normal
6. Additional Notes