Fix: Display correctly barcode from tesco lotus on checkout success page.

[jacstn]

1. Objective

Display barcode fix.
There is error that barcode is not displayed on tesco lotus page.
This PR deliver fix for that functionality.

2. Description of change

Just renamed function to get proper array value.

array value we are pointing in:
TescoAdditionalInformation.php:39 is named tesco_code_image,
but we try to get by calling getTescoCodeUrl:
tesco_code_url

We removed img tag, because we display Tesco barcode using SVG code.
In that PR also was changed array key represents Tesco image displayed in checkout success page.
tesco_code_image => tesco_barcode_svg.

and getter function was renamed to getTescoBarcodeSvg.

3. Quality assurance

🔧 Environments:

• Platform version: Magento CE 2.2.3.
• Omise plugin version: Omise-Magento 2.6.
• PHP version: 7.0.29.

✏️ Details:

Make Tesco Payment,
See if barcode is displayed properly.

4. Impact of the change

Solve issue

5. Priority of change

High,

6. Additional Notes

None

[guzzilar]

@jacstn just wanna point out that actually looking at this change without understanding the context seems a bit strange.
While the code is changed to getTescoCodeImage() but we removed <img></img> tag.

[jacstn]

after digging deeper into code, we still display in HTML - SVG code.

SVG is converted to HTML only when it is necessary - before sending it in email.

img with src was necessary when we were using URL to SVG file.
I renamed it to getTescoBarcodeSvg and corresponding array key to: tesco_barcode_svg

[guzzilar]

Just realised a small point that the code is inconsistent:

3: <p style="margin:.5rem 0"><?= $block->escapeHtml(__('Amount to pay'))?>: <strong><?= $block->getOrderAmount();?></b></strong>
4: <div><?= $block->getTescoBarcodeSvg() ?></div>

// 1 space after <?= but no space before ?>
<?= $block->escapeHtml(__('Amount to pay'))?>

// Same as above, but end with ;
<?= $block->getOrderAmount();?>

// 1 space after <?= and before ?>
<?= $block->getTescoBarcodeSvg() ?>

The change LGTM 👍