Fix for unable to select some installment terms #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacstn
changed the title
jacstn
force-pushed
the
2-cant-select-interests-fix
branch
2 times, most recently
from
74844b4 to
11145f9
Compare
jacstn
force-pushed
the
2-cant-select-interests-fix
branch
from
11145f9 to
c1f249e
Compare
jonrandy
approved these changes
May 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Objective
This PR fix issue that the user cannot select some terms.
Currently selectable is the only number of installments (terms) that exists in each of Installment options.
For instance, 5 installments are available only Krungthai Card option so they are not selectable.
10 installments are available in each option so they are selectable for a user.
2. Description of change
This PR separates observables for terms of each installment option.
Each installment brand has own terms observable.
It used to be single observable for all brand's terms.
3. Quality assurance
✏️ Details:
To manually test that PR you need to make payment with installment number that is not available in all options (ie. 5 installments using KTC) and make payment using terms available in all options (ie. 10 installments in BAY)
4. Impact of the change
N/A
5. Priority of change
Normal