Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage cards link on checkout page #197

Merged
merged 4 commits into from
May 22, 2019
Merged

Manage cards link on checkout page #197

merged 4 commits into from
May 22, 2019

Conversation

jacstn
Copy link
Contributor

@jacstn jacstn commented May 21, 2019

1. Objective

This PR adds a link to checkout / payments / credit cards page, to easily go to managing cards page where a user can delete cards.

2. Description of change

Just adds link and TH translation

3. Quality assurance

  • Platform version: Magento CE 2.2.3.
  • Omise plugin version: Omise-Magento 2.7.
  • PHP version: 7.0.16.

✏️ Details:

  1. Make sure you have saved any credit cards.
    Go to checkout, choose credit card payment, see if Manage your cards link is available. Click on the link, and see if you are moved to customer panel/managing cards page.

image

  1. Make sure you don't have any saved cards.
    Manage your cards link should not be visible.

4. Impact of the change

N/A

5. Priority of change

Normal

6. Additional Notes

N/A

@jonrandy
Copy link
Contributor

"Select a card you want to proceed" doesn't make sense - "Select a card to proceed" is better

Copy link
Contributor

@jonrandy jonrandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a language change (English). Not related to these changes, but not spotted before

Copy link
Contributor

@guzzilar guzzilar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not quite really sure in what case that user want to jump out from "finishing purchasing an order" to "delete card". Do you have any real use case that have been reported to us before? @jacstn

@jacstn
Copy link
Contributor Author

jacstn commented May 22, 2019

for me @guzzilar it is easy to imagine when you come back to the store after some time and you see some old cards saved... no need to search in platform how to manage them, easy to imagine that it will be quite useful.

@jacstn
Copy link
Contributor Author

jacstn commented May 22, 2019

but target="_blank" could be better here.

@jacstn jacstn requested a review from jonrandy May 22, 2019 06:25
@guzzilar
Copy link
Contributor

guzzilar commented May 22, 2019

@jacstn Still don't see much point in a real use case here.
Maybe we feel like we need a link to be there because we mostly "test" the system so there will be a lot of cases where we feel the need to jump between "deleting cards" and "placing an order" (as we have to test save card several times to the point that we feel that it would be nice to have a quick access to delete all the cards we saved).

But in reality, will you just come to the checkout page just to delete a saved card?
Or will user really going to intervene themselves from finishing the purchase to delete a card first?

@jacstn jacstn merged commit 4d8ba52 into master May 22, 2019
@jacstn jacstn deleted the 2-manage-cards-link branch May 22, 2019 10:38
@jacstn
Copy link
Contributor Author

jacstn commented May 22, 2019

you will not go specifically to the checkout page to delete saved card, it is just option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants