-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manage cards link on checkout page #197
Conversation
"Select a card you want to proceed" doesn't make sense - "Select a card to proceed" is better |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a language change (English). Not related to these changes, but not spotted before
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not quite really sure in what case that user want to jump out from "finishing purchasing an order" to "delete card". Do you have any real use case that have been reported to us before? @jacstn
for me @guzzilar it is easy to imagine when you come back to the store after some time and you see some old cards saved... no need to search in platform how to manage them, easy to imagine that it will be quite useful. |
but |
@jacstn Still don't see much point in a real use case here. But in reality, will you just come to the checkout page just to delete a saved card? |
you will not go specifically to the checkout page to delete saved card, it is just option. |
1. Objective
This PR adds a link to checkout / payments / credit cards page, to easily go to managing cards page where a user can delete cards.
2. Description of change
Just adds link and TH translation
3. Quality assurance
✏️ Details:
Go to checkout, choose credit card payment, see if Manage your cards link is available. Click on the link, and see if you are moved to customer panel/managing cards page.
Manage your cards link should not be visible.
4. Impact of the change
N/A
5. Priority of change
Normal
6. Additional Notes
N/A