Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Too many parameters are sent to parent class in DeleteAction - fix #213

Merged
merged 1 commit into from
Jul 30, 2019

Conversation

jacstn
Copy link
Contributor

@jacstn jacstn commented Jul 30, 2019

1. Objective

Delete Action, too many parameters sent to parent class when constructing the object.

Related information:
Related issue(s): #211

2. Description of change

This PR fixes error when running dicompilecommand. More information can be found in the issue linked above.

3. Quality assurance

Specify where and how you tested this and what further testing it might need.

🔧 Environments:

  • Platform version: Magento CE 2.2.5.
  • Omise plugin version: Omise-Magento 2.1.
  • PHP version: 7.0.16.

✏️ Details:

Test 1
Run php bin/magento setup:di:compile, the command should be finished with no problem.
Test 2
Remove successfully previously saved credit card information.

4. Impact of the change

N/A

5. Priority of change

Normal

6. Additional Notes

N/A

@jacstn jacstn requested review from jonrandy and guzzilar July 30, 2019 01:31
@jacstn jacstn changed the title too many parameters sent to parent controller in DeleteAction - fix Too many parameters are sent to parent class in DeleteAction - fix Jul 30, 2019
@jacstn jacstn merged commit bb49af4 into master Jul 30, 2019
@jacstn jacstn deleted the fix-for-delete-action-dicompile-err branch July 30, 2019 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants