Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for new currencies #218

Merged
merged 1 commit into from
Sep 6, 2019
Merged

Adding support for new currencies #218

merged 1 commit into from
Sep 6, 2019

Conversation

jacstn
Copy link
Contributor

@jacstn jacstn commented Sep 4, 2019

1. Objective

This PR adds support of all currencies offered currently by Omise.

2. Description of change

This PR adds new currencies to be considered in the amount formatting function.

3. Quality assurance

  • Platform version: Magento CE 2.1.5.
  • Omise plugin version: Omise-Magento 2.1.
  • PHP version: 7.0.16.

✏️ Details:

  1. Change the currency of Magento 2 store to any new currency offered by Omise (ie. DKK Danish Korona).
  2. Make a successful order payment.
  3. Verify if the amount of order is the same in Magento history and Omise Dashboard

4. Impact of the change

N/A

5. Priority of change

Normal

6. Additional Notes

N/A

@jacstn jacstn requested review from guzzilar and jonrandy September 4, 2019 07:59
@jacstn jacstn changed the title Addd support for new currencies Adding support for new currencies Sep 4, 2019
@jacstn jacstn merged commit f5525b2 into master Sep 6, 2019
@jacstn jacstn deleted the 2-add-currencies branch September 6, 2019 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants