Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FRON-972] #325

Merged
merged 7 commits into from
Feb 15, 2022
Merged

[FRON-972] #325

merged 7 commits into from
Feb 15, 2022

Conversation

timothyOmise
Copy link
Contributor

1. Objective

Only allow the sending of invoices to happen 1 time.

2. Description of change

On sending of invoice the invoice id is added to magento cache, cache is checked for presence of invoice key before sending

3. Quality assurance

Ensure that invoice emails are only sent one time

🔧 Environments:

  • Platform version: Magento CE 2.20.4.
  • Omise plugin version: Omise-Magento 2.13
  • PHP version: 7.0.16.

✏️ Details:

Create a charge on magneto store that is processed by 3DS. Ensure invoice emails are only send once.

4. Impact of the change

N/A

5. Priority of change

High

6. Additional Notes

None

Copy link
Contributor

@kan98 kan98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏽 please update the composer file and changelog too

@timothyOmise timothyOmise merged commit 369e953 into master Feb 15, 2022
@aashishgurung aashishgurung deleted the feature/FRON-972 branch September 27, 2022 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants