[APM2-749] Add bbl mobile banking #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tookaa2
requested review from
new4762,
aashishgurung,
FhanOmise,
hpariwat,
jutinapas and
kan98
new4762
reviewed
May 20, 2022
| @@ -44,7 +44,14 @@ define( | |||
| code: 'bay', | |||
| logo: 'bay', | |||
| currencies: ['thb'], | |||
| active: false | |||
| active: true | |||
| }, { | |||
There was a problem hiding this comment.
maybe need to adjust { to new line here
new4762
approved these changes
May 20, 2022
kan98
approved these changes
May 23, 2022
FhanOmise
approved these changes
May 23, 2022
aashishgurung
approved these changes
May 23, 2022
hpariwat
approved these changes
May 23, 2022
|
Testing on staging with Mobile Banking BBL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Objective
Add support for Mobile Banking BBL
2. Description of change
Add support for deeplink BBL and enable other mobile banking types
3. Quality assurance
Specify where and how you tested this and what further testing it might need.
🔧 Environments:
Specify the details of your test environments, including, for each, the platform version (on which the plugin was run), the Omise plugin version, and the versions of your system software such as PHP or Ruby.
i.e.
✏️ Details:
Enable mobile banking bbl source_type for merchant and ensure the payment method appears when check out on THB store
4. Impact of the change
Allow customer to pay using mobile banking bbl (on mobile only)
5. Priority of change
Normal
6. Additional Notes
Any further information that you would like to add.