Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rms wallet #366

Merged
merged 21 commits into from
Aug 29, 2022
Merged

Add rms wallet #366

merged 21 commits into from
Aug 29, 2022

Conversation

new4762
Copy link
Contributor

@new4762 new4762 commented Jul 15, 2022

1. Objective

Add support RMS wallets payment methods

  • Touch 'n Go
  • Boost
  • Maybank QR Pay
  • ShopeePay
  • GrabPay
  • DuitNow QR
  • DuitNow OBW

2. Description of change

Add support all RMS wallet payment methods and make Touch 'n Go to be more generic name

3. Quality assurance

make sure all RMS payment methods is display correctly and can click pay
🔧 Environments:

Specify the details of your test environments, including, for each, the platform version (on which the plugin was run), the Omise plugin version, and the versions of your system software such as PHP or Ruby.

Platform version: Magento CE 2.2.3
Omise plugin version: Omise-Magento 2.27.0
Omise plugin version: Omise-php v2.13
PHP version: 7.1

✏️ Details:

right now ours capability api still didn't update correctly
if you want to testing it try using this mock server with this json data

{
   "object":"capability",
   "location":"/capability",
   "banks":[
      "PHBMMYKL"
   ],
   "limits":{
      "charge_amount":{
         "max":1000000,
         "min":3000
      },
      "transfer_amount":{
         "max":10000000,
         "min":1
      }
   },
   "payment_backends":[
      {
         "boost":{
            "type":"boost",
            "currencies":[
               "myr"
            ],
            "amount":{
               "min":3000,
               "max":1000000
            },
            "provider":"RMS"
         }
      },
      {
         "duitnow_obw":{
            "type":"duitnow_obw",
            "currencies":[
               "myr"
            ],
            "amount":{
               "min":3000,
               "max":1000000
            },
            "provider":"RMS"
         }
      },
      {
         "duitnow_qr":{
            "type":"duitnow_qr",
            "currencies":[
               "myr"
            ],
            "amount":{
               "min":3000,
               "max":1000000
            },
            "provider":"RMS"
         }
      },
      {
         "grabpay":{
            "type":"grabpay",
            "currencies":[
               "myr"
            ],
            "amount":{
               "min":3000,
               "max":1000000
            },
            "provider":"RMS"
         }
      },
      {
         "maybank_qr":{
            "type":"maybank_qr",
            "currencies":[
               "myr"
            ],
            "amount":{
               "min":3000,
               "max":1000000
            },
            "provider":"RMS"
         }
      },
      {
         "shopeepay":{
            "type":"shopeepay",
            "currencies":[
               "myr"
            ],
            "amount":{
               "min":3000,
               "max":1000000
            },
            "provider":"RMS"
         }
      },
      {
         "touch_n_go":{
            "type":"touch_n_go",
            "currencies":[
               "jpy",
               "sgd",
               "myr",
               "thb"
            ],
            "amount":{
               "min":3000,
               "max":1000000
            },
            "provider":"Alipay_plus"
         }
      }
   ],
   "tokenization_methods":[
      
   ],
   "zero_interest_installments":false
}

4. Impact of the change

  • add new payment methods
  • update Touch 'n Go displayname

image

image

image

image

image

image

image

5. Priority of change

Normal

6. Additional Notes

will need to release after update capability api

@new4762 new4762 self-assigned this Jul 15, 2022
@new4762 new4762 marked this pull request as ready for review July 15, 2022 05:29
@new4762
Copy link
Contributor Author

new4762 commented Jul 20, 2022

Some details update after add logo and rename 🙏
image
image

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
13.0% 13.0% Duplication

@new4762 new4762 merged commit 4021903 into enhancements-display-payment-options Aug 29, 2022
new4762 added a commit that referenced this pull request Aug 29, 2022
* update prevent save

* fix renderer logic

* 🆙 date renderer to using capabilities api 📈

* some clean up

* Clean up v1 🧼

* fix M2 Coding standard

* fix M2 Coding standard v2

* fix M2 Coding standard v3

* fix M2 Coding standard v4

* fix M2 Coding standard v5

* fix M2 Coding standard v6

* update

* fix following comment

* fix wrong replace value

* forgot to remove unused value

* Update Helper/OmiseHelper.php

Co-authored-by: Pariwat Hongladarom <61586978+hpariwat@users.noreply.github.com>

* update following comment

* move to function

* fix m2 v7

* fix m2 v8

* Update Plugin/ConfigSectionPaymentPlugin.php

Co-authored-by: Ponpol Wongsapjinda <donutzue@gmail.com>

* fix some bug

* fix after merge

* Add rms wallet (#366)

* some change

* some config

* fix

* add order id

* fix format

* finish v1

* finish v2

* make tng generic

* some fix

* some missing update

* fix name Maybank QR

* update & add logo for RMS & some other payment

* Revert "fix name Maybank QR"

This reverts commit 3357655.

* update Touch`n Go eWallet display name

* update duitnow display name

* make 2.28.0.alpha version

* fix following sonar

* remove comment code smell

* add support multi-store

* fix m2 v1

* fix m2 v2

* fix m2 v3

* fix m2 v4

* final fix m2

Co-authored-by: Pariwat Hongladarom <61586978+hpariwat@users.noreply.github.com>
Co-authored-by: Ponpol Wongsapjinda <donutzue@gmail.com>
@new4762 new4762 mentioned this pull request Aug 30, 2022
@aashishgurung aashishgurung deleted the add-rms-wallet branch September 27, 2022 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants