-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rms wallet #366
Merged
new4762
merged 21 commits into
enhancements-display-payment-options
from
add-rms-wallet
Aug 29, 2022
Merged
Add rms wallet #366
new4762
merged 21 commits into
enhancements-display-payment-options
from
add-rms-wallet
Aug 29, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hpariwat
approved these changes
Jul 15, 2022
tookaa2
approved these changes
Jul 15, 2022
kan98
approved these changes
Jul 18, 2022
aashishgurung
approved these changes
Jul 18, 2022
FhanOmise
approved these changes
Jul 19, 2022
FhanOmise
reviewed
Jul 19, 2022
Kudos, SonarCloud Quality Gate passed!
|
new4762
added a commit
that referenced
this pull request
Aug 29, 2022
* update prevent save * fix renderer logic * 🆙 date renderer to using capabilities api 📈 * some clean up * Clean up v1 🧼 * fix M2 Coding standard * fix M2 Coding standard v2 * fix M2 Coding standard v3 * fix M2 Coding standard v4 * fix M2 Coding standard v5 * fix M2 Coding standard v6 * update * fix following comment * fix wrong replace value * forgot to remove unused value * Update Helper/OmiseHelper.php Co-authored-by: Pariwat Hongladarom <61586978+hpariwat@users.noreply.github.com> * update following comment * move to function * fix m2 v7 * fix m2 v8 * Update Plugin/ConfigSectionPaymentPlugin.php Co-authored-by: Ponpol Wongsapjinda <donutzue@gmail.com> * fix some bug * fix after merge * Add rms wallet (#366) * some change * some config * fix * add order id * fix format * finish v1 * finish v2 * make tng generic * some fix * some missing update * fix name Maybank QR * update & add logo for RMS & some other payment * Revert "fix name Maybank QR" This reverts commit 3357655. * update Touch`n Go eWallet display name * update duitnow display name * make 2.28.0.alpha version * fix following sonar * remove comment code smell * add support multi-store * fix m2 v1 * fix m2 v2 * fix m2 v3 * fix m2 v4 * final fix m2 Co-authored-by: Pariwat Hongladarom <61586978+hpariwat@users.noreply.github.com> Co-authored-by: Ponpol Wongsapjinda <donutzue@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Objective
Add support RMS wallets payment methods
2. Description of change
Add support all RMS wallet payment methods and make Touch 'n Go to be more generic name
3. Quality assurance
make sure all RMS payment methods is display correctly and can click pay
🔧 Environments:
Specify the details of your test environments, including, for each, the platform version (on which the plugin was run), the Omise plugin version, and the versions of your system software such as PHP or Ruby.
Platform version: Magento CE 2.2.3
Omise plugin version: Omise-Magento 2.27.0
Omise plugin version: Omise-php v2.13
PHP version: 7.1
✏️ Details:
right now ours capability api still didn't update correctly
if you want to testing it try using this mock server with this json data
4. Impact of the change
5. Priority of change
Normal
6. Additional Notes
will need to release after update capability api