[ENGA3-510]: Issue of two invoices of the same order has been fixed.

[aashishgurung]

1. Objective

Fix the issue of two invoices of the same order.

Jira Ticket: #510

2. Description of change

The default value of Generate invoice at order status was set to \Magento\Sales\Model\Order::STATE_PENDING_PAYMENT. So, comparing the return value of $this->config->getSendInvoiceAtOrderStatus() with Order::STATE_PENDING_PAYMENT for equality was failing. We had to manually change the value to set the proper value which are either pending_payment and processing.

With this PR, we changed the default value to pending_payment. For the merchants who have already installed our plugin, we added an if check that returns pending_payment from Order:STATE_PENDING_PAYMENT if the setting's value is \Magento\Sales\Model\Order::STATE_PENDING_PAYMENT.

After the fix

Screen.Recording.2565-10-10.at.15.16.12.mov

Before the fix

Screen.Recording.2565-10-10.at.15.35.21.mov

3. Quality assurance

• Platform version: Magento 2.4.5
• Omise plugin version: Omise-Magento 2.29.1
• PHP version: 8.1

✏️ Details:

• Enable webhook
• Enable credit card
• Set payment action to Authorize and Capture
• Checkout with 3DS.

You should see only one invoice and the amount should be paid.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication

[davidhanh]

@aashishgurung Do you think you an also include a screencast in the PR's description? It will be easier to understand what the changes are about.

[aashishgurung]

@aashishgurung Do you think you an also include a screencast in the PR's description? It will be easier to understand what the changes are about.

I have included the recording of placing an order.