Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENGA3-540] : Bug fixed on partial refund #399

Merged
merged 6 commits into from
Dec 6, 2022

Conversation

ajzkk
Copy link
Contributor

@ajzkk ajzkk commented Dec 2, 2022

1. Objective

Bug fixed on partial refund

Partial refund was not working since getGrandTotalAmount() was using in RefundDataBuilder
Instead get order from payment and get proper store_id, order currency and online refunded amount.

Related information:
ENGA3-540

2. Description of change

  • get order from payment and get proper store_id, order currency and online refunded amount.

3. Quality assurance

  • Please test with different store, different currency and do full refund and partial refund

4. Impact of the change

N/A

5. Priority of change

Normal

6. Additional Notes

N/A

@ajzkk ajzkk requested a review from aashishgurung as a code owner December 2, 2022 10:00
@ajzkk ajzkk requested review from davidhanh, kan98 and new4762 December 2, 2022 10:00
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 6, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@ajzkk ajzkk merged commit e708ca6 into master Dec 6, 2022
@aashishgurung aashishgurung deleted the bug/ENGA3-540-bug-fixed-on-refund branch December 14, 2022 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants