Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENGA3-677] : Replace card-form with pay.js embedded form #410

Merged
merged 16 commits into from
Mar 22, 2023

Conversation

ajzkk
Copy link
Contributor

@ajzkk ajzkk commented Mar 7, 2023

1. Objective

Replace card-form with pay.js embedded form

ENGA3-677

2. Description of change

  • replaced card form with pay.js embedded card form
  • added a page for embedded form customization.

3. Quality assurance

Tested locally

4. Impact of the change

N/A

5. Priority of change

N/A

@ajzkk ajzkk requested a review from aashishgurung as a code owner March 7, 2023 02:15
@ajzkk ajzkk marked this pull request as draft March 7, 2023 02:22
@ajzkk ajzkk marked this pull request as ready for review March 7, 2023 03:34
@ajzkk ajzkk requested review from danfowler and a team March 7, 2023 03:34
@ajzkk ajzkk self-assigned this Mar 7, 2023
@ajzkk ajzkk removed the request for review from a team March 7, 2023 04:18
@ajzkk ajzkk requested review from danfowler and aashishgurung March 8, 2023 09:29
@aashishgurung
Copy link
Contributor

It is convention to add extra empty line at the end of the file. Could you please add it for consistency?

@ajzkk
Copy link
Contributor Author

ajzkk commented Mar 8, 2023

It is convention to add extra empty line at the end of the file. Could you please add it for consistency?

@aashishgurung I believe I added for all files, which file did I miss to add?

@aashishgurung
Copy link
Contributor

aashishgurung commented Mar 8, 2023

My bad. Ignore my feedback. I was looking into Github files. I forgot Github will show automatically if the newline is missing at the end of file.

@ajzkk ajzkk marked this pull request as draft March 9, 2023 07:53
@ajzkk ajzkk marked this pull request as ready for review March 22, 2023 04:18
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@ajzkk ajzkk changed the base branch from master to develop March 22, 2023 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants