-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENGA3-677] : Replace card-form with pay.js embedded form #410
[ENGA3-677] : Replace card-form with pay.js embedded form #410
Conversation
Block/Adminhtml/System/Config/CardFormCustomization/FormModal.php
Outdated
Show resolved
Hide resolved
Block/Adminhtml/System/Config/CardFormCustomization/form-modal.html
Outdated
Show resolved
Hide resolved
Block/Adminhtml/System/Config/CardFormCustomization/form-modal.html
Outdated
Show resolved
Hide resolved
It is convention to add extra empty line at the end of the file. Could you please add it for consistency? |
@aashishgurung I believe I added for all files, which file did I miss to add? |
My bad. Ignore my feedback. I was looking into Github files. I forgot Github will show automatically if the newline is missing at the end of file. |
Kudos, SonarCloud Quality Gate passed! |
1. Objective
Replace card-form with pay.js embedded form
ENGA3-677
2. Description of change
3. Quality assurance
Tested locally
4. Impact of the change
N/A
5. Priority of change
N/A