Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Atome failed due to sub product amount zero #433

Merged
merged 9 commits into from
Jun 1, 2023

Conversation

ajzkk
Copy link
Contributor

@ajzkk ajzkk commented May 29, 2023

1. Objective

Bug fixed Atome failed due to sub product amount zero

2. Description of change

  • Remove sub products with amount zero
  • When sub total is zero, show error message Complimentary products cannot be billed.

3. Quality assurance

Tested locally with Atome payment method when

  • Sub total is zero
  • Bundle product has sub product with amount zero
  • And normal product order

4. Impact of the change

N/A

5. Priority of change

Normal

6. Additional Notes

@ajzkk ajzkk requested a review from aashishgurung as a code owner May 29, 2023 06:40
@ajzkk ajzkk marked this pull request as draft May 29, 2023 06:40
@ajzkk ajzkk marked this pull request as ready for review May 29, 2023 09:18
@ajzkk ajzkk requested review from danfowler and annatotest May 29, 2023 09:18
@ajzkk ajzkk requested review from danfowler and aashishgurung June 1, 2023 03:59
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@ajzkk ajzkk requested a review from danfowler June 1, 2023 05:24
@ajzkk ajzkk merged commit 5a1c64e into develop Jun 1, 2023
@aashishgurung aashishgurung deleted the bug/atome-failed-sub-product-amount-zero branch November 17, 2023 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants