Be able to make a charge with Internet Banking payment method #65
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Objective
Continue from PR #64.
To be able to make a charge with the Internet Banking payment solution.
Related information:
Related issue(s): 🙅
2. Description of change
Fix bank icon stylesheet.

Update the Internet Banking checkout form, to have real implementation with the real values.
Javascript, update the Internet Banking payment object, by observing radio buttons at the Internet Banking checkout form.
Add a new
payment_method_assign_data_omise_offsite_internetbanking
event and observer class to observe the parameter that frontend submit through the checkout form.etc/DI.XML, update real dependencies (classes that work with
OmiseOffsiteInternetbankingAdapter
), seeOmiseOffsiteInternetbankingCommandPool
(virtual object).Implement
Gateway\RequestBuilder
,Gateway\Client
,Gateway\Validator
classes that need to handlebuild request object >> request to gateway service >> handle & validate the result
steps.3. Quality assurance
🔧 Environments:
✏️ Details:
✅ Test be able to checkout with the Internet Banking payment method.
Enable the Internet Banking payment solution at the admin payment setting page.
Do normal checkout process, and choose one of bank from the bank list.
Then, charge will be completed and redirect buyer to the succesful page. (here, this PR will not validate the payment result).
Check at Omise dashboard, you will see the transaction that made by above step.


Back to Magento's admin order list page, you will see the last transaction was made with payment Internet Banking payment method.

4. Impact of the change
You may need to clear cache if you can't see the result.
SYSTEM > Cache Management
Flush Magento Cache
. (or you can choose to disable all caches while testing).5. Priority of change
Normal
6. Additional Notes