Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate a 3-D Secure payment result at the callback uri #78

Merged
merged 9 commits into from
Apr 11, 2017

Conversation

guzzilar
Copy link
Contributor

@guzzilar guzzilar commented Apr 10, 2017

⚠️ This PR is a part of 3-D Secure implementation, PR #76

1. Objective

To validate a 3-D Secure payment result and update an order status, invoice and transaction.

Related information:
Related issue(s): 🙅

2. Description of change

• New callback uri, omise/callback/threedsecure

• Add new controller to handle the validation process on the callback uri.

• Introduce new validation structure and enhance the process between validate & raise an error

3. Quality assurance

🔧 Environments:

  • Platform version: Magento CE 2.1.5.
  • Omise plugin version: Omise-Magento 2.0.
  • PHP version: 7.0.16.

✏️ Details:

  1. ✅ Test access to the callback uri directly, user will be redirected to the checkout/cart page and an error will be raised.
    screen shot 2560-04-11 at 2 41 16 pm

  2. ✅ Test validate a charge result with Order.status != pending payment, user will be redirected to the checkout/cart page and an error will be raised.

    • An error message will be saved into an order history comment section.
  3. ✅ If payment method != omise or omise_cc, user will be redirected to the checkout/cart page and an error will be raised.

    • An error message will be saved into an order history comment section.
  4. ✅ If cannot retrieve a charge id from a target order, user will be redirected to the checkout/cart page and an error will be raised.

    • An error message will be saved into an order history comment section.
    • If it has, invoice will be set to canceled.
    • Perform cancel order.
  5. ✅ Test validate a charge response with payment action = authorize. It should works properly.

    • An order status will be set to processing
  6. ✅ Test validate a charge response with payment action = authorize_capture. It should works properly.

    • An order status will be set to processing
    • An invoice will be created with the status paid
    • A transaction will be created and omise.transaction.id will be attached to the transaction record.
    • A transaction status will be set to closed
  7. ✅ Test charge with a failed card test, both authorize and authorize_capture will redirect user to the checkout/cart page and raise an error on a screen.

    • An error message will be saved into an order history comment section.
    • If it has, invoice will be set to canceled.
    • Perform cancel order.

4. Impact of the change

No

5. Priority of change

Normal

6. Additional Notes

No

@guzzilar
Copy link
Contributor Author

👍

@guzzilar guzzilar merged commit b80cf29 into 3ds Apr 11, 2017
@guzzilar guzzilar deleted the validate-charge-result branch April 11, 2017 08:04
@guzzilar guzzilar changed the title [WIP] Validate a 3-D Secure payment result at the callback uri Validate a 3-D Secure payment result at the callback uri Apr 11, 2017
@guzzilar guzzilar mentioned this pull request Apr 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant