Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce minLength and maxLength validation for strings #111

Merged
merged 1 commit into from
Sep 30, 2023

Conversation

AlbertoBarba
Copy link
Contributor

Introduce string validations:
6.3.1 maxlength
6.3.2 minlength

@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Patch coverage: 96.15% and project coverage change: +0.52% 🎉

Comparison is base (1ca1837) 78.14% compared to head (aa887ab) 78.67%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #111      +/-   ##
==========================================
+ Coverage   78.14%   78.67%   +0.52%     
==========================================
  Files          10       10              
  Lines        1446     1496      +50     
==========================================
+ Hits         1130     1177      +47     
- Misses        244      246       +2     
- Partials       72       73       +1     
Files Changed Coverage Δ
pkg/generator/validator.go 94.33% <90.90%> (-0.90%) ⬇️
pkg/generator/generate.go 76.18% <100.00%> (+0.48%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@omissis omissis self-requested a review September 30, 2023 12:39
@omissis omissis merged commit 5362d2e into omissis:main Sep 30, 2023
@omissis omissis deleted the feat/string-validation branch September 30, 2023 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants