Correct definition of MultipleOf and ExclusiveMaximum. #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #116 +/- ##
=======================================
Coverage 78.14% 78.14%
=======================================
Files 10 10
Lines 1446 1446
=======================================
Hits 1130 1130
Misses 244 244
Partials 72 72
☔ View full report in Codecov by Sentry. 📢 Have feedback on the report? Share it here. |
omissis
reviewed
Sep 30, 2023
| Maximum float64 `json:"maximum,omitempty"` // Section 5.2. | ||
| ExclusiveMaximum bool `json:"exclusiveMaximum,omitempty"` // Section 5.3. | ||
| ExclusiveMaximum float64 `json:"exclusiveMaximum,omitempty"` // Section 5.3. | ||
| Minimum float64 `json:"minimum,omitempty"` // Section 5.4. | ||
| ExclusiveMinimum bool `json:"exclusiveMinimum,omitempty"` // Section 5.5. |
There was a problem hiding this comment.
ExclusiveMinimum should be a number, too
|
@deep-creek I checked the spec and in a previous draft it was a boolean. I'm ok with updating it, but I guess Exclusive Minimum should be a float64 |
|
Replaced by #127 (just a rebased from main and added one missing type conversion). Thanks for your contribution! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both should be float64 according to http://json-schema.org/draft/2020-12/json-schema-validation.html#name-multipleof