Only perform minItems validation when field is provided #122
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #86, minItems validation is being applied even when a non-required field is omitted from the input json.
A json schema like
should pass against an empty object input
(can be tested at https://www.jsonschemavalidator.net/)
Instead the generated code will result in an error during unmarshal. The proposed solution is to just add a
nil
check - non-required slices useomitempty
, which means they end upnil
if not supplied. If the field is required, the earlier field presence check will catch these - but also they'll never benil
becauseomitempty
is not used under such circumstances. So overall this additional constraint seems safe to add. Happy to take direction on other approaches.